This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
feat: keep string literal quote in table default #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merge when kwilteam/kwil-db#353 is merged |
Yaiba
force-pushed
the
feature/table-default-string-literal-quote
branch
from
6cac79a
to
0d9e665
Compare
jchappelow
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @brennanjl required, kuneiform will preserve the quote for string literal in table default. This is related to kwilteam/kwil-db#353
This will make the behavior consistent in Kuneiform when receive a literal string value: